Review: Needs Fixing
Just a couple of small things I noticed, but lgtm otherwise
Diff comments:
> diff --git
> a/frontend/src/components/base/TablePagination/_TablePagination.scss
> b/frontend/src/components/base/TablePagination/_TablePagination.scss
> index c663d8f..3c96af4 100644
> --- a/frontend/src/components/base/TablePagination/_TablePagination.scss
> +++ b/frontend/src/components/base/TablePagination/_TablePagination.scss
> @@ -34,16 +35,16 @@
> }
>
> // Remove input arrows
> +
> /* Chrome, Safari, Edge, Opera */
> input::-webkit-outer-spin-button,
> input::-webkit-inner-spin-button {
> - -webkit-appearance: none;
This line needs to be ignored since it affects the appearance of the pagination
input, and just setting "appearance" on the input won't work.
> + appearance: none;
> margin: 0;
> }
>
> /* Firefox */
> input[type="number"] {
> - -moz-appearance: textfield;
Same goes for this line as above
> appearance: textfield;
> }
>
--
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442220
Your team MAAS Committers is subscribed to branch
~petermakowski/maas-site-manager:enable-stylelint.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : [email protected]
Unsubscribe : https://launchpad.net/~sts-sponsors
More help : https://help.launchpad.net/ListHelp
