This bug seems to not be a "bitesize". It would need more investigation (there may be more patches needed to actually get that fix), because the https://git.launchpad.net/simplestreams/commit/?id=21782a0d0b45b13dca1d712a1c889b68cdb1e4f5 does not fix that bug. I was trying to find a commit that would fix that, but none of them were suitable. Moreover, I compared the source code in Focal (where it works) and Bionic and moreover, Eoan and the files after applying the commit: 21782a0d0b45b13dca1d712a1c889b68cdb1e4f5 to Bionic were binary equal - what is interesting. Since Bionic reaches EOSS in June 2023 and it's a low priority bug, I am going to unassign myself, remove the server-todo tag and close that bug.
** Tags removed: server-todo ** Description changed: - [Impact] - - * Simple Streams describe streams of like items in a structural fashion. - A client provides a way to sync or act on changes in a remote stream. - - * Users of simplestreams' sstream-mirror command using --max flag - reported a filtering crash on Bionic. - - * This crash is caused by the BasicMirrorWriter class, which did not - include applying filters to items before filtering versions. The fix is - based on adding a patch with missing code. - - [Test Plan] - - Make a container for testing: - - $ lxc launch ubuntu-daily:bionic bionic-test - $ lxc shell bionic-test - - Type in: - - $ apt install simplestreams - - $ sstream-mirror --no-verify --max=1 --progress - --path=streams/v1/index2.sjson https://streams.canonical.com/juju/tools - ./ arch=amd64 'release~(xenial|bionic)' 'version ~(2.4|2.6)' --dry-run - - Example of failed output: - - 0 Mb change - - Example of successful output: - - ... - + com.ubuntu.juju:18.04:amd64 20191029 2.6.10-bionic-amd64 agent/2.6.10/juju-2.6.10-ubuntu-amd64.tgz 29 Mb - + com.ubuntu.juju:16.04:amd64 20191029 2.6.10-xenial-amd64 agent/2.6.10/juju-2.6.10-ubuntu-amd64.tgz 29 Mb - + com.ubuntu.juju:18.04:amd64 20191029 2.6.10-bionic-amd64 agent/2.6.10/juju-2.6.10-ubuntu-amd64.tgz 29 Mb - 174 Mb change - - - [Where problems could occur] - - * The patch itself modifies the code of the BasicMirrorWriter class in - the __init__.py, so regression can be limited to items filtering, - reading checksums or deleting filtered products. - - - -----------------------------original bug report------------------------ On eoan: ubuntu@eoan:~$ apt list --installed simplestreams Listing... Done simplestreams/eoan,now 0.1.0-25-gba75825b-0ubuntu1 all [installed] ubuntu@eoan:~$ sstream-mirror --no-verify --max=1 --progress --path=streams/v1/index2.sjson https://streams.canonical.com/juju/tools ./ arch=amd64 'release~(xenial|bionic)' 'version~(2.4|2.6)' --dry-run + com.ubuntu.juju:16.04:amd64 20190503 2.6-rc2-xenial-amd64 agent/2.6-rc2/juju-2.6-rc2-ubuntu-amd64.tgz 28 Mb + com.ubuntu.juju:18.04:amd64 20190503 2.6-rc2-bionic-amd64 agent/2.6-rc2/juju-2.6-rc2-ubuntu-amd64.tgz 28 Mb + com.ubuntu.juju:16.04:amd64 20191029 2.6.10-xenial-amd64 agent/2.6.10/juju-2.6.10-ubuntu-amd64.tgz 29 Mb + com.ubuntu.juju:18.04:amd64 20191029 2.6.10-bionic-amd64 agent/2.6.10/juju-2.6.10-ubuntu-amd64.tgz 29 Mb + com.ubuntu.juju:16.04:amd64 20191029 2.6.10-xenial-amd64 agent/2.6.10/juju-2.6.10-ubuntu-amd64.tgz 29 Mb + com.ubuntu.juju:18.04:amd64 20191029 2.6.10-bionic-amd64 agent/2.6.10/juju-2.6.10-ubuntu-amd64.tgz 29 Mb 174 Mb change On bionic: root@iptv-receiver:~# apt list --installed simplestreams Listing... Done simplestreams/bionic,now 0.1.0-490-g3cc8988-0ubuntu1~ubuntu18.04.1 all [installed] N: There are 2 additional versions. Please use the '-a' switch to see them. root@bionic:~# sstream-mirror --no-verify --max=1 --progress --path=streams/v1/index2.sjson https://streams.canonical.com/juju/tools ./ arch=amd64 'release~(xenial|bionic)' 'version ~(2.4|2.6)' --dry-run 0 Mb change Same thing with the non-dev version (from bionic-updates): root@bionic:~# apt list --installed simplestreams Listing... Done simplestreams/bionic-updates,now 0.1.0~bzr460-0ubuntu1.1 all [installed,upgradable to: 0.1.0-490-g3cc8988-0ubuntu1~ubuntu18.04.1] N: There is 1 additional version. Please use the '-a' switch to see it root@bionic:~# sstream-mirror --no-verify --max=1 --progress --path=streams/v1/index2.sjson https://streams.canonical.com/juju/tools ./ arch=amd64 'release~(xenial|bionic)' 'version ~(2.4|2.6)' --dry-run 0 Mb change ** Changed in: simplestreams (Ubuntu Bionic) Status: In Progress => Won't Fix ** Changed in: simplestreams (Ubuntu Bionic) Assignee: Michał Małoszewski (michal-maloszewski99) => (unassigned) -- You received this bug notification because you are a member of MAAS Maintainers, which is subscribed to simplestreams in Ubuntu. https://bugs.launchpad.net/bugs/1870360 Title: sstream-mirror max options doesn't work with filtering for versions Status in simplestreams package in Ubuntu: Fix Released Status in simplestreams source package in Bionic: Won't Fix Status in simplestreams source package in Eoan: Fix Released Bug description: On eoan: ubuntu@eoan:~$ apt list --installed simplestreams Listing... Done simplestreams/eoan,now 0.1.0-25-gba75825b-0ubuntu1 all [installed] ubuntu@eoan:~$ sstream-mirror --no-verify --max=1 --progress --path=streams/v1/index2.sjson https://streams.canonical.com/juju/tools ./ arch=amd64 'release~(xenial|bionic)' 'version~(2.4|2.6)' --dry-run + com.ubuntu.juju:16.04:amd64 20190503 2.6-rc2-xenial-amd64 agent/2.6-rc2/juju-2.6-rc2-ubuntu-amd64.tgz 28 Mb + com.ubuntu.juju:18.04:amd64 20190503 2.6-rc2-bionic-amd64 agent/2.6-rc2/juju-2.6-rc2-ubuntu-amd64.tgz 28 Mb + com.ubuntu.juju:16.04:amd64 20191029 2.6.10-xenial-amd64 agent/2.6.10/juju-2.6.10-ubuntu-amd64.tgz 29 Mb + com.ubuntu.juju:18.04:amd64 20191029 2.6.10-bionic-amd64 agent/2.6.10/juju-2.6.10-ubuntu-amd64.tgz 29 Mb + com.ubuntu.juju:16.04:amd64 20191029 2.6.10-xenial-amd64 agent/2.6.10/juju-2.6.10-ubuntu-amd64.tgz 29 Mb + com.ubuntu.juju:18.04:amd64 20191029 2.6.10-bionic-amd64 agent/2.6.10/juju-2.6.10-ubuntu-amd64.tgz 29 Mb 174 Mb change On bionic: root@iptv-receiver:~# apt list --installed simplestreams Listing... Done simplestreams/bionic,now 0.1.0-490-g3cc8988-0ubuntu1~ubuntu18.04.1 all [installed] N: There are 2 additional versions. Please use the '-a' switch to see them. root@bionic:~# sstream-mirror --no-verify --max=1 --progress --path=streams/v1/index2.sjson https://streams.canonical.com/juju/tools ./ arch=amd64 'release~(xenial|bionic)' 'version ~(2.4|2.6)' --dry-run 0 Mb change Same thing with the non-dev version (from bionic-updates): root@bionic:~# apt list --installed simplestreams Listing... Done simplestreams/bionic-updates,now 0.1.0~bzr460-0ubuntu1.1 all [installed,upgradable to: 0.1.0-490-g3cc8988-0ubuntu1~ubuntu18.04.1] N: There is 1 additional version. Please use the '-a' switch to see it root@bionic:~# sstream-mirror --no-verify --max=1 --progress --path=streams/v1/index2.sjson https://streams.canonical.com/juju/tools ./ arch=amd64 'release~(xenial|bionic)' 'version ~(2.4|2.6)' --dry-run 0 Mb change To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/simplestreams/+bug/1870360/+subscriptions -- Mailing list: https://launchpad.net/~sts-sponsors Post to : [email protected] Unsubscribe : https://launchpad.net/~sts-sponsors More help : https://help.launchpad.net/ListHelp
