[
https://issues.apache.org/jira/browse/SUBMARINE-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16806042#comment-16806042
]
Anthony Hsu edited comment on SUBMARINE-40 at 3/31/19 3:10 AM:
---------------------------------------------------------------
Hi, thanks for the patch, [[email protected]]. Have a few minor comments:
* looks like there are ASF license issues, checkstyle issues, and compilation
issues. Can you fix these?
**
[https://builds.apache.org/job/PreCommit-SUBMARINE-Build/35/artifact/out/patch-asflicense-problems.txt]
**
[https://builds.apache.org/job/PreCommit-SUBMARINE-Build/35/artifact/out/diff-checkstyle-hadoop-submarine.txt]
(I think a lot have to do with some patch files using 4 space indentation
instead of the expected 2)
**
[https://builds.apache.org/job/PreCommit-SUBMARINE-Build/35/artifact/out/branch-mvnsite-hadoop-submarine_hadoop-submarine-yarnservice-runtime.txt]
* In TonyJobSubmitter.java
** Include *rnfe* in *LOG.error("GPU resources not enabled.");*
** Add *@Override* to *onApplicationIdReceived*
** Remove the comment "// ensure notebook application is killed when this
client process terminates"
** Refactor converting ClientContext to Configuration to TonyUtils
** ClientContext is stored as a field but seems unused
* in JobStatusBuilder.java
** add default clause to switch statement (checkstyle also complains about
this)
** What is the difference between ready vs. running? When a job
succeeds/fails, should the status be set back to ready?
was (Author: erwaman):
Hi, thanks for the patch, [[email protected]]. Have a few minor comments:
* looks like there are ASF license issues, checkstyle issues, and compilation
issues. Can you fix these?
**
[https://builds.apache.org/job/PreCommit-SUBMARINE-Build/35/artifact/out/patch-asflicense-problems.txt]
**
[https://builds.apache.org/job/PreCommit-SUBMARINE-Build/35/artifact/out/diff-checkstyle-hadoop-submarine.txt]
(I think a lot have to do with some patch files using 4 space indentation
instead of the expected 2)
**
[https://builds.apache.org/job/PreCommit-SUBMARINE-Build/35/artifact/out/branch-mvnsite-hadoop-submarine_hadoop-submarine-yarnservice-runtime.txt]
* In TonyJobSubmitter.java
** Include *rnfe* in *LOG.error("GPU resources not enabled.");*
** **add *@Override* to *onApplicationIdReceived*
** Remove the comment "// ensure notebook application is killed when this
client process terminates"
** Refactor converting ClientContext to Configuration to TonyUtils
** ClientContext is stored as a field but seems unused
* in JobStatusBuilder.java
** add default clause to switch statement (checkstyle also complains about
this)
** What is the difference between ready vs. running? When a job
succeeds/fails, should the status be set back to ready?
> Add TonY runtime to Submarine
> -----------------------------
>
> Key: SUBMARINE-40
> URL: https://issues.apache.org/jira/browse/SUBMARINE-40
> Project: Hadoop Submarine
> Issue Type: New Feature
> Affects Versions: 0.2.0
> Reporter: Keqiu Hu
> Assignee: Keqiu Hu
> Priority: Major
> Labels: submarine, tony
> Fix For: 0.2.0
>
> Attachments: SUBMARINE-40.003.patch, SUBMARINE-40.patch
>
> Original Estimate: 504h
> Remaining Estimate: 504h
>
> Currently Submarine depends on YARN native service, we need another runtime
> to support Hadoop versions w/o native service. Plan is to add a TonY runtime
> into Submarine eco system.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
