[
https://issues.apache.org/jira/browse/SUBMARINE-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824924#comment-16824924
]
Szilard Nemeth commented on SUBMARINE-54:
-----------------------------------------
Thanks [~tangzhankun]!
As per our offline discussion with [~tangzhankun]:
1. I won't fix VisibilityModifier checkstyle issues as these are originating
from protected fields not being private and do not have getters. That does not
make sense for me to fix.
2. Missing package-info.java files are added.
3. I generally don't fix HiddenField issues, so I'll do the same with this
patch.
4. TestTFConfigGenerator, line longer issue: This class needs a cleanup
already, so I won't fix this as I haven't touched the class.
5. Fixed the line longer issues of checkstyle
Zhankun: As we discussed, this is ready for commit!
> Add test coverage for YarnServiceJobSubmitter and make it ready for extension
> for PyTorch
> -----------------------------------------------------------------------------------------
>
> Key: SUBMARINE-54
> URL: https://issues.apache.org/jira/browse/SUBMARINE-54
> Project: Hadoop Submarine
> Issue Type: Sub-task
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: SUBMARINE-54.001.patch, SUBMARINE-54.002.patch,
> SUBMARINE-54.003.patch, SUBMARINE-54.004.patch, SUBMARINE-54.005.patch,
> SUBMARINE-54.006.patch, SUBMARINE-54.007.patch, SUBMARINE-54.008.patch,
> SUBMARINE-54.009.patch, SUBMARINE-54.009.patch
>
>
> This crucial class has no associated test yet. We need to improve this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
