[
https://issues.apache.org/jira/browse/SUBMARINE-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835689#comment-16835689
]
Hadoop QA commented on SUBMARINE-66:
------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
52s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 20m
28s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
27s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
17s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
27s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
2m 30s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 0m
39s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
38s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 12s{color} | {color:orange}
hadoop-submarine/hadoop-submarine-yarnservice-runtime: The patch generated 2
new + 0 unchanged - 4 fixed = 2 total (was 4) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
13m 29s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 55s{color}
| {color:red} hadoop-submarine-yarnservice-runtime in the patch failed. {color}
|
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
26s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 43m 40s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.yarn.submarine.runtimes.yarnservice.tensorflow.command.TestTensorFlowLaunchCommand
|
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-SUBMARINE-Build/90/artifact/out/Dockerfile
|
| JIRA Issue | SUBMARINE-66 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12968202/SUBMARINE-66.001.patch
|
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux 51183aa74cdb 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec
10 13:20:24 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 9b0aace |
| Default Java | 1.8.0_191 |
| checkstyle |
https://builds.apache.org/job/PreCommit-SUBMARINE-Build/90/artifact/out/diff-checkstyle-hadoop-submarine_hadoop-submarine-yarnservice-runtime.txt
|
| unit |
https://builds.apache.org/job/PreCommit-SUBMARINE-Build/90/artifact/out/patch-unit-hadoop-submarine_hadoop-submarine-yarnservice-runtime.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-SUBMARINE-Build/90/testReport/ |
| Max. process+thread count | 304 (vs. ulimit of 10000) |
| modules | C: hadoop-submarine/hadoop-submarine-yarnservice-runtime U:
hadoop-submarine/hadoop-submarine-yarnservice-runtime |
| Console output |
https://builds.apache.org/job/PreCommit-SUBMARINE-Build/90/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.11.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Improve TF config env JSON generator + tests
> --------------------------------------------
>
> Key: SUBMARINE-66
> URL: https://issues.apache.org/jira/browse/SUBMARINE-66
> Project: Hadoop Submarine
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: SUBMARINE-66.001.patch
>
>
> org.apache.hadoop.yarn.submarine.runtimes.yarnservice.tensorflow.TensorFlowCommons#getTFConfigEnv
> generates a JSON of the TF_CONFIG environment variable.
> This code could be improved to use a JSON serializer instead of hand-crafting
> JSON data.
> The test class of this class also could be improved:
> org.apache.hadoop.yarn.submarine.runtimes.yarnservice.TestTFConfigGenerator
> In this class, there are some quite unreadable JSON strings, this could be
> refactored to be read out from a file instead.
> TestTFConfigGenerator has only one testcase and it's ugly, as we use very
> long strings to verify the JSON data produced matches our expected JSON.
> We should use JSON files instead of manually constructing Strings in tests,
> especially if they are very long.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
