[
https://issues.apache.org/jira/browse/SUBMARINE-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838323#comment-16838323
]
Szilard Nemeth commented on SUBMARINE-49:
-----------------------------------------
Hi [~adam.antal]!
Thanks for the review!
In general, the patch changed much between version 003 and 004 as PyTorch
integration is merged to trunk (SUBMARINE-49), I needed to rebase this patch on
top of trunk and there were many conflicts.
Replying to your comments:
1. Agreed with your point on the need of defining some testcases for
RoleResourceParser. Please check the testcases I added with patch005
2. As I needed to rebase this patch on top of trunk,
RunJobParameters$validateWorkersAndPs is not a method anymore.
3. Added a javadoc to method RunJobParameters#setDefaultDirs.
4. Fixed the wildcard imports.
Fixed the checkstyle issues (that made sense) as well resulted from patch004.
> Add more test coverage to RunJobParameters
> ------------------------------------------
>
> Key: SUBMARINE-49
> URL: https://issues.apache.org/jira/browse/SUBMARINE-49
> Project: Hadoop Submarine
> Issue Type: Sub-task
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
> Attachments: SUBMARINE-49.001.patch, SUBMARINE-49.002.patch,
> SUBMARINE-49.003.patch, SUBMARINE-49.004.patch, SUBMARINE-49.004.patch
>
>
> There are some good tests in
> {{org.apache.hadoop.yarn.submarine.client.cli.TestRunJobCliParsing}}, but
> these are not testing all fields set by method
> {{org.apache.hadoop.yarn.submarine.client.cli.param.RunJobParameters#updateParametersByParsedCommandline}}.
>
> Some more extensive testing is needed in this area.
> As an added bonus, the code
> {{org.apache.hadoop.yarn.submarine.client.cli.param.RunJobParameters#updateParametersByParsedCommandline}}
> could be cleaned up a bit.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
