[
https://issues.apache.org/jira/browse/SUBMARINE-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840493#comment-16840493
]
Peter Bacsko commented on SUBMARINE-62:
---------------------------------------
Just one thing: wouldn't it be better to extract strings like "PS", "worker",
"Tensorboard" to a constant?
> PS_LAUNCH_CMD CLI description is wrong in RunJobCli
> ---------------------------------------------------
>
> Key: SUBMARINE-62
> URL: https://issues.apache.org/jira/browse/SUBMARINE-62
> Project: Hadoop Submarine
> Issue Type: Bug
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: SUBMARINE-62.001.patch
>
>
> See:
> [https://github.com/apache/hadoop/blob/trunk/hadoop-submarine/hadoop-submarine-core/src/main/java/org/apache/hadoop/yarn/submarine/client/cli/RunJobCli.java#L118-L120]
> Currently, the description is:
> "Commandline of worker, arguments will be directly used to launch the PS"
> Shouldn't the description start with "Commandline of PS..."?
> The rest of it can remain intact.
> [~tangzhankun]: What's your opinion?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
