[
https://issues.apache.org/jira/browse/SUBMARINE-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16842161#comment-16842161
]
Szilard Nemeth commented on SUBMARINE-68:
-----------------------------------------
Hi [~adam.antal]!
Thanks for the valuable comments!
1. Yep, it was indeed a red flag. Please check my updated solution for this
issue.
2. Fixed the javadoc
3. Extracted the temp dir File object into a new static final field as you
suggested.
4. Fixed the javadoc of downloadRemoteFile
5. Extracted the constant from getMaxRemoteFileSizeMB
6. Removed the Non HDFS comment as it was not make any sense
7. Fixed the manually crafted File path string as you suggested. Good point!
Btw, these are not my code so I kinda inherited and not created file paths by
hand, intentionally.
Testcases:
1. Indeed, the setupService method was copied from another place and did not
make sense in this place at all.
2. Moved FILE_SCHEME to the suggested place.
3. Yes, these files are cleaned up.
> Add tests to FileSystemOperations class
> ---------------------------------------
>
> Key: SUBMARINE-68
> URL: https://issues.apache.org/jira/browse/SUBMARINE-68
> Project: Hadoop Submarine
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
> Attachments: SUBMARINE-68.001.patch, SUBMARINE-68.002.patch,
> SUBMARINE-68.003.patch, SUBMARINE-68.004.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
