liuxunorg commented on a change in pull request #22: SUBMARINE-207. Exclude
mysql jdbc jar from the path of workbench/lib.
URL: https://github.com/apache/hadoop-submarine/pull/22#discussion_r329355291
##########
File path:
submarine-workbench/workbench-server/src/main/java/org/apache/submarine/server/SubmarineConfiguration.java
##########
@@ -374,7 +374,7 @@ public boolean getBoolean(String envName, String
propertyName, boolean defaultVa
"failOverReadOnly=false&zeroDateTimeBehavior=convertToNull&useSSL=false"),
JDBC_USERNAME("jdbc.username", "submarine"),
JDBC_PASSWORD("jdbc.password", "password"),
- WORKBENCH_WEB_WAR("workbench.web.war",
"submarine-workbench/workbench-web/dist");
+ WORKBENCH_WEB_WAR("workbench.web.war", "../workbench/workbench-web.war");
Review comment:
Don't Modify `WORKBENCH_WEB_WAR` default value.
If change `WORKBENCH_WEB_WAR` default value. then cannot run/debug
WorkbenchServer directly in IDEA directly, because WorkbenchServer module not
contain `workbench-web.war`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
