Peter Avalos wrote:
http://www.theshell.com/~pavalos/wip/atc.diff

* The functions in grammar.y should be static (including yyerror()).

* If y1 is going to be renamed to y_1 for the check_line() parameter then it should also be x_1, x_2 and y_2, IMO. Too bad the Bessel functions occupy some useful names. :)

* If you feel like it, the atc.6 manpage needs to be converted to mdoc.

Otherwise, the patch looks fine to me.

Sascha

--
http://yoyodyne.ath.cx

Reply via email to