On Tue, 2014-02-11 at 19:49 +0100, Patrick Majewski wrote: > Hi, > I am Patrick Majewski, a German developer and diver. I like what you all > did with Subsurface. Especially after the switch to Qt. This enables me > to give some value back. Cause this is my first time I send a patch to > an oss, please be kind if I'm doing it wrong ;)
Nothing wrong, this looks great! > If I click in the Preferences Dialog on the 3 dots to choose a default > File to load and cancel the opening File Dialog an empty string is > returned and set to the corresponding QLineEdit. > The new behavior (and mostly expected) is to update the QLineEdit only > if there is a filename returned from QFileDialog. Agreed. Good catch and thanks for your contribution! /D _______________________________________________ subsurface mailing list [email protected] http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
