On Fri, Feb 14, 2014 at 12:33 PM, Boris Barbulovski <[email protected]>wrote:
> > > > On Fri, Feb 14, 2014 at 7:15 AM, Dirk Hohndel <[email protected]> wrote: > >> On Thu, 2014-02-13 at 22:48 +0100, Boris Barbulovski wrote: >> > >> > >> > This patch adds recent files list into main menu. >> >> My guess is that outside of the developers most people only ever use one >> file, their default file. But especially for people who maintain a >> divelog for two people this might be really useful. >> I"m not sure I'm in love with the way this is done (in the File Menu) >> and in a way it seems a bit confusing together with the default file, >> but I'll let others play with it and speak up. >> >> > It adds upto four filenames to the File menu. >> >> That sounds reasonable. >> >> > Originally I intended to show tooltip of absolute pathname on menu >> > item mouse hover, but failed to do so(room for future improvements). >> >> Speaking of future improvement. What happened to your indentation >> settings? Or more specifically, to your curly brace positioning? >> That's pure Allman style, and as much as I like Eric, his husband and >> his sister... the brace style he brought to the world is really >> terrible. Way too much wasted vertical space... >> >> > Ahh, sorry for that. As I write other Qt software with Allman style, I > forgot to change my coding style. > Soon I will post another merge request fixing the curly brace positioning. > > I used this as an excuse to tweak my little automated whitespace / >> coding style tool a little more and run it over mainwindow.cpp (the file >> which you treated to so much extra vertical spread). >> >> I kinda like the result. Not perfect, but a HUGE improvement. >> >> Again, I'd love to hear what others think. >> >> /D >> >> >> > > > -- > *Boris Barbulovski* > http://mkfusion.bokicsoft.com/ > > > -- *Boris Barbulovski* http://mkfusion.bokicsoft.com/
_______________________________________________ subsurface mailing list [email protected] http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
