dirk, can you test the patch? I couldn`t really understand why it crashed
if not static, since we should always have that object.
saing that - the correct way to handle that should be from the Settings, no?
QSettings s;
s.value("lastUsedImageDirectory").toString() or something
On Tue, Feb 18, 2014 at 8:26 PM, Robert C. Helling <hell...@atdotde.de>wrote:
>
> On 17 Feb 2014, at 23:57, Dirk Hohndel <d...@hohndel.org> wrote:
>
> >
> > This does not include the promised whitespace overhaul.
> > Instead I added a few outstanding patches and went down the rabbit hole
> > of trying to track down a crash with Robert's image shift patches.
> >
> > Here's how I can reliably reproduce this.
> >
> > Open a dive log in Subsurface - one of the test dives will do.
> > Right click on a dive and pick "load images"
> > Pick a few images
> > Click "select image of divecomputer showing time
> > select one
> > click OK
> >
> > This reliably overwrites memory with garbage for me. Depending how many
> > images I pick and which ones, it often leads to a crash.
> >
> > Tomaz offered to look at this as I wasted way too much time on it
> > (basically I lost all the time I had intended to cleanup the code base
> > instead). So I am checking this in, but be careful - you have been
> > warned that this overwrites memory, so don't play with it using your
> > ream data file.
> >
>
>
>
> I don’t know enough C++ to understand why this patch works but the upshot
> is: The crash was caused when lastUsedImageDir was called from another
> class and was called via on DiveList object. Making it a static function to
> be called with DiveList::lastUsedImageDir makes the crash go away.
>
> Good night
> Robert
>
> --
>
> .oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO
> Robert C. Helling Elite Master Course Theoretical and Mathematical
> Physics
> Scientific Coordinator
> Ludwig Maximilians Universitaet Muenchen, Dept.
> Physik
> print "Just another Phone: +49 89 2180-4523 Theresienstr. 39, rm. B339
> stupid .sig\n"; http://www.atdotde.de
>
>
> _______________________________________________
> subsurface mailing list
> subsurface@hohndel.org
> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
>
>
_______________________________________________
subsurface mailing list
subsurface@hohndel.org
http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
