Hi Dirk, Thanks for the feedback. Just check these two patches. Please tell me the one that is correct. I will make sure that, I send the patches that way from next time with a similar SOB line.
Yes, Even I am trying to figure out what's wrong with my workflow. Let's see if this works. Regards, Gopichand On Wed, Mar 5, 2014 at 10:40 PM, Dirk Hohndel <[email protected]> wrote: > On Wed, 2014-03-05 at 22:19 +0530, Gopichand Paturi wrote: > > Hello All, > > This is a very minor patch involving adding some useful terms into > > terms.txt file. > > Firstly let me know if I made any patch mistakes. This time I don't > > want to repeat them. > > > > > > I did not put a commit message since this is very minor(felt header is > > enough). > > Also let me know if I had gone wrong with my SOB message. > > There should be an empty line before the SOB. Once again it is connected > to the subject of the patch which will fail. > Please try again. I really wonder how you create the commit message and > then create the patch. Something in that workflow must be odd... > > > Regarding the patch, I added some terms like trimix , heliox, nitrox > > and about compartments which I felt would be handy while reading the > > code. > > Feel free to discard them if you feel they aren't necessary. > > I think they are good additions. > > > I made sure that it's from the latest master. > > Good :-) > > /D > > >
From d30a71361613f211416ee1e72c92104580ffbcd1 Mon Sep 17 00:00:00 2001 From: g1g19 <[email protected]> Date: Wed, 5 Mar 2014 22:06:59 +0530 Subject: [PATCH] Added new terms which can be a useful reference Signed-off-by: Gopichand Paturi <[email protected]> --- terms | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/terms b/terms index 0e771c4..8fec5a7 100644 --- a/terms +++ b/terms @@ -30,6 +30,12 @@ O₂%, He% The fraction of Oxygen and Helium in a gas. pressure is 4atm) therefore has a PO₂ of 4 * 0.30 = 1.2 +Trimix Gas Mixture containing Helium, Oxygen and Nitrogen. + +Heliox Gas Mixture containing Helium and Oxygen. + +Nitrox Gas Mixture containing Nitrogen and Oxygen. + CSV Comma separated values - a common file format TSV Tab separated values - a common file format @@ -119,3 +125,7 @@ EADD equivalent air density depth TTS time to surface (including deco stop and reasonable ascent speed) + +TC Tissue Compartment, is a logical tissue interface to various + tissues in the human body. Since each tissue has its own gas + dissolving time, they have been categorized into compartments. -- 1.7.9.5
From d30a71361613f211416ee1e72c92104580ffbcd1 Mon Sep 17 00:00:00 2001 From: g1g19 <[email protected]> Date: Wed, 5 Mar 2014 22:06:59 +0530 Subject: [PATCH] Added new terms which can be a useful reference Signed-off-by: Gopichand Paturi <[email protected]> --- terms | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/terms b/terms index 0e771c4..8fec5a7 100644 --- a/terms +++ b/terms @@ -30,6 +30,12 @@ O₂%, He% The fraction of Oxygen and Helium in a gas. pressure is 4atm) therefore has a PO₂ of 4 * 0.30 = 1.2 +Trimix Gas Mixture containing Helium, Oxygen and Nitrogen. + +Heliox Gas Mixture containing Helium and Oxygen. + +Nitrox Gas Mixture containing Nitrogen and Oxygen. + CSV Comma separated values - a common file format TSV Tab separated values - a common file format @@ -119,3 +125,7 @@ EADD equivalent air density depth TTS time to surface (including deco stop and reasonable ascent speed) + +TC Tissue Compartment, is a logical tissue interface to various + tissues in the human body. Since each tissue has its own gas + dissolving time, they have been categorized into compartments. -- 1.7.9.5
_______________________________________________ subsurface mailing list [email protected] http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
