On Sun, Mar 30, 2014 at 11:52 AM, Robert C. Helling <[email protected]> wrote:
>
> On 30 Mar 2014, at 18:26, Lakshman <[email protected]> wrote:
>
>> The attached patch tries to resolve the looping issue with the
>> "entered" branch of yours. I am assuming that you were referring to
>> this in irc today morning, I was sleeping then and missed it.
>
> Lakshman,
>
> I think your patch does with the new state variable emitPointEdit that 
> prevents the recursive calling is not a solution because it creates a race 
> condition: Imagine in drawProfile it is set to false and then via the UI the 
> user creates a new point by double clicking.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
I didn't like what I did here. Its a naive hack, wrote quickly by
keeping your branch in mind. The point you mentioned is what I was
referring as one of the things that needs to be addressed, hence the
patch is partial.

> I have no better solution myself but I would think we have to better handle 
> the dataChanged signal/slot (basically not call plan when the data change is 
> due to added calculated deco stops). But I am not sure
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
how to do that.
>
I have been working on creating another table widget all together and
pushing new waypoints into it, in the slightly similar lines you
mentioned, so far its working well, but still in experimental stage
and I believe that can do what we want and will send the patch soon.

Thank you,
Lakshman
_______________________________________________
subsurface mailing list
[email protected]
http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

Reply via email to