On 02 April, 2014 - Andrey Zhdanov wrote: > > > Why do we got this adjustment of the header hight to begin with? > > First row is too close to header. > > > Its this adjustment in header height that hides the first trip marker in > > the Android port, because the first trip row ends up behind the header. > > Can you show screenshot how it looks in the Android port? >
Really ugly url but this was the simplest way: With the 10px extra: header()->setMinimumHeight(metrics.height() + 10) https://lh4.googleusercontent.com/-zb9SGCYqoQ8/Uzvb-c3goyI/AAAAAAAAAeU/TNylc6HbyZ4/w1106-h622-no/Screenshot_2014-04-02-11-44-16.png Without the 10 exta: https://lh6.googleusercontent.com/-MHzas6b-jNc/Uzvc0sknVCI/AAAAAAAAAeg/sxDiNFdmlcs/w1106-h622-no/Screenshot_2014-04-02-11-47-54.png > > I've looked at the tables in both Qt4 and Qt5 on Linux and Qt5 on > > Android and all the tables looks still sane without this adjustment. > > As it is stated in ticket #360, it is only mac problem. > We should then make the layout fix only on the mac builds, and maybe try to get a layout fix upstream. //Anton > >> On 02 April, 2014 - Andrey Zhdanov wrote: > >> > >> Fix height of first line in dive list by reducing header height by 3px. > >> > >> Fixes #360 > >> > >> Signed-off-by: Andrey Zhdanov <[email protected]> > >> --- > >> qt-ui/divelistview.cpp | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/qt-ui/divelistview.cpp b/qt-ui/divelistview.cpp > >> index d9f5eb9..9ad6dcf 100644 > >> --- a/qt-ui/divelistview.cpp > >> +++ b/qt-ui/divelistview.cpp > >> @@ -43,7 +43,7 @@ DiveListView::DiveListView(QWidget *parent) : > >> QTreeView(parent), mouseClickSelec > >> setContextMenuPolicy(Qt::DefaultContextMenu); > >> header()->setContextMenuPolicy(Qt::ActionsContextMenu); > >> const QFontMetrics metrics(defaultModelFont()); > >> - header()->setMinimumHeight(metrics.height() + 10); > >> + header()->setMinimumHeight(metrics.height() + 7); > >> header()->setStretchLastSection(true); > >> QAction *showSearchBox = new QAction(tr("Show Search Box"), this); > >> showSearchBox->setShortcut(Qt::CTRL + Qt::Key_F); > >> -- > >> 1.8.5.2 (Apple Git-48) > >> > >> _______________________________________________ > >> subsurface mailing list > >> [email protected] > >> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface > > > > -- > > Anton Lundin +46702-161604 -- Anton Lundin +46702-161604 _______________________________________________ subsurface mailing list [email protected] http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
