On Apr 10, 2014, at 2:30 PM, Thiago Macieira <[email protected]> wrote:
> Em qui 10 abr 2014, às 19:12:50, Joshua Joseph escreveu: >> The attached patch is my attempt at OS name/version detection. I have not >> yet tested >> it on windows, nor added the Mac part. Just wanted some comments on the >> same. > > Hello Josh > > Thanks for the work, but can I ask you to hold back for a few more days? > You're backporting my code from Qt 5.4, but it's still being modified. Once > we > have it settled, we can backport to Subsurface and be sure we get the same > results. This is my fault. I pushed him to work on it… > I'd also like a more direct backport -- try to keep the functions intact, if > possible, even if you can't modify QSysInfo like I can[*]. This will allow > for > easier updating in the future, in case we find a bug that needs to be fixed > and > backported. I am equally fine with you submitting a version to your liking, Thiago. > For example, the need to read /etc/lsb-release so we can detect > Ubuntu… mumble, grumble, whatever /D _______________________________________________ subsurface mailing list [email protected] http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
