This semester I have 6 to-do projects 2 will be finished by next tuesday then, I will work on this one.
Regards, Yousef Hamza On Mon, Apr 14, 2014 at 5:06 PM, Dirk Hohndel <[email protected]> wrote: > On Mon, 2014-04-14 at 09:23 -0500, Lakshman wrote: > > On Mon, Apr 14, 2014 at 7:30 AM, Dirk Hohndel <[email protected]> wrote: > > > > > > This works well - but when playing with it I noticed that currently > > > edits are broken - they don't modify the data in the dive. > > > > > > This is not something that your patch broke, though. I'll need to > figure > > > out when that happened. > > > > > Dirk, there have been attempts to address this bug, here are ones (I > > am sorry, if I am missing any other patches) taken from mailing list > > (patches are not shown in mailing list archive). > > > > 1) http://lists.hohndel.org/pipermail/subsurface/2014-March/010849.html > > 2) http://lists.hohndel.org/pipermail/subsurface/2014-March/011129.html > > > > Please correct me if I am wrong. Earlier you stated that, these values > > should not be changed, since we should not mess with the values taken > > from dive computer. In this mail, when you pointed this bug again, do > > you mean "even if the value is not taken from dive computer, why is > > subsurface not allowing us to edit them?" > > We keep getting ourselves confused on this one. It's actually not hard. > > We have a summary value for each of the temperatures in the dive struct. > That's the one we display. That's the one we should edit. And we need to > make sure that we also save it. And load it. It's not hard, but AFAIK > none of the patches actually got it right. > > But then again, I may have missed the correct fix - so if you have a > patch that > a) edits the dive structure > b) doesn't change the divecomputer structure(s) > c) does the right thing when the XML/git is saved and loaded again > then please resend it to me with a good commit message and I'll be happy > to apply it. > > I'm at a conference for a couple of days and hopefully should have a > little time for Subsurface (famous last words) > > /D > >
_______________________________________________ subsurface mailing list [email protected] http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
