On Mon, May 12, 2014 at 10:20:56PM -0300, Tomaz Canabrava wrote: > > audit the code is something I think we really should do. I was trying > to untangle > some of the code and a few stuff I can't understand by it's name what it does, > for instance 'get_dc_nickname' seems to set the dc nickname instead of > returning > it.
For each function that makes no sense, send an email here and people will explain it. Even with Linus and me out for a week, there are plenty of people here who understand the C code very well. That said, get_dc_nickname is now in the C++ code and it does appear to do what the name indicates. It looks for the dive computer. If we have a nickname, it returns that, otherwise it returns the model. As for the audit - I really think we need to do this as part of creating the unit tests. So this is one big, convoluted project to make this testable and more stable. Depending on how much time I have on the boat between all the diving, I'll take a stab at this. I'm sure it will end in disaster, without being able to google for answers to random questions :-) > right now I'm doing what anton asked me, porting the planner code to > the new profile, > so I think I'll finish this by this week. That's useful. Thanks /D _______________________________________________ subsurface mailing list [email protected] http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
