Great patch series. Thank you! One small comment:
On Wed, May 21, 2014 at 01:08:50PM -0300, Tomaz Canabrava wrote: > From 79f3db466778c6c912ca8c2f63acba67c37a67ea Mon Sep 17 00:00:00 2001 > From: Tomaz Canabrava <[email protected]> > Date: Wed, 21 May 2014 12:06:02 -0300 > Subject: [PATCH 2/5] Create a 'remove_event' function that removes an event. > > The logic of removing the event was in the UI, and this makes > the code harder to test because we need to take into account > also the events that the interface is receiving, instead of > only relying on the algorithm to test. > > so, now it lives in dive.h/.c and a unittest is easyer to make. Would have been even cuter if you had included a matching unit test :-) /D _______________________________________________ subsurface mailing list [email protected] http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
