On Wed, May 28, 2014 at 9:02 PM, Gehad <[email protected]> wrote:
> Here is two more patches attached that gives us a better exporter.
>
> -Handling the output of Null values.
> -adding location to the columns.
> -adding the search shortcuts for searching tags and locations.
>
>
>
> On 05/28/2014 12:17 AM, Gehad wrote:
>
>> I am attaching my progress in the JSON exporter, I Fixed what Miika has
>> mentioned before.
>> Now we can view the trip list by pressing trip button (some features
>> needs to be deactivated when viewing trip list).
>>
>
This seems to be broken when exporting only selected dives. Even when
selecting every single dive on my list and exporting *selected*, I get no
dive trips. However, when exporting all dives, it seems to work. At least I
tend to export full trips, unlike your assumption that exporting individual
dives should not include the trips. Since HTML export is going to need the
theme selection, the export dialog could have tabs, one for standard
exports and one for the HTML export. And the HTML export could have "all
dives", "selected dives", "selected dives with trips". Or do people have
better suggestions?
When the trip view is toggled, there should be visual indication of that.
> also attached the HTML and js files with additional color theme and fixed
>> the patches (removed whitespaces).
>>
>
These should be included in Subsurface sources properly at some point. E.g.
having a directory for the themes and copying these files to the export
directory (based on theme selection). But I suppose this already in your
to-do list.
Some comments on the sources below:
+void export_HTML(const char *file_name, const bool selected_only)
...
+ f = fopen(file_name, "w+");
+ if (!f)
+ printf("error"); /*report error*/
Error should be shown on the GUI. report_error function can be used for
that.
+ flush_buffer(&buf, f); /*check for writing errors? */
yes please.
Quoting the output strings is missing from write_one_dive function as is
localization support. As put_HTML_tags is missing the quotation as well.
I'll send the current set of patches for Dirk to include to master. I just
fixed two typos on one comment...
miika
_______________________________________________
subsurface mailing list
[email protected]
http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
