On Fri, May 30, 2014 at 11:14 AM, Dirk Hohndel <[email protected]> wrote: > On Fri, May 30, 2014 at 08:54:13AM -0300, Tomaz Canabrava wrote: >> On Fri, May 30, 2014 at 12:57 AM, Dirk Hohndel <[email protected]> wrote: >> > On Fri, May 30, 2014 at 02:24:50AM +0300, Gehad wrote: >> >> Patch attached to fix the order of quoting to prevents the corruption of >> >> format. >> > >> > I'll take the patch as it's rather straight forward, but I have my >> > misgivings about the whole way quote() has been implemented. >> > >> > Take a look at the quote function in save-git.c for example... wouldn't >> > that be a much smarter design? One pass through the string, replace things >> > as you go? >> >> QString.toHtmlScaped(); > > That's Qt5 only. Qt4 has .escape() - which indeed does some of what we > want but not all of it. > In general I think this would be a fine case of creating a Qt helper that > is called from C code. > > It's fun to reinvent the wheel in C. It's not always the best use of time > and energy.
yup - the qt version works, it's fast, and can be easily integrated on C code by a helper function, it will remove around 50 - 60 loc to three or four, so it's worth it. > /D _______________________________________________ subsurface mailing list [email protected] http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
