On Tue, Jun 17, 2014 at 1:12 AM, Gehad Elrobey <[email protected]> wrote:
> > > > On Sun, Jun 15, 2014 at 7:55 AM, Miika Turkia <[email protected]> > wrote: > >> Here is the latest set of Gehad's patches with my singed-off included. I >> have also some comments here. >> >> - You delete the theme.css but not the other template files when copying? >> If any other of the template files has changed in Subsurface, they are not >> updated. >> - The detailed view does not work for manually added dives. >> >> > > Manual add dives work ok with me, can you send me the dive file please? > I seem to be getting the following error on JS Error Console: TypeError: end is undefined list_lib.js:715 A sample dive attached. > > > >> There is also one whitespace issue, but it seems to be someone else's >> doing. (It seems that the whitespace checker scrips works reasonably well >> on JS files. And it really should be run against those as well, as there is >> quite a bit of inconsistent spacing in there. When running it we'll just >> need to be extra careful to make sure it is only "cosmetic" changes that >> occur.) >> >> > > I Attached some patches to fix the JS format and checked that it doesn't > corrupt anything. > Also Fixed the deletion of other template files. > Looks good whan taking a very quick peek at the files. I'll take another look later. miika
<divelog program='subsurface' version='2'> <settings> <autogroup state='1' /> </settings> <dives> <dive number='6' tags='boat' date='2006-08-27' time='15:32:00' duration='35:00 min'> <location>Portugal Azores Arches (Arcos da Caloura)</location> <divemaster>Henrique Araújo</divemaster> <notes>Vedenalaisia kaaria Suit: 7mm märkkis Weight: 8kg</notes> <suit>7mm full</suit> <cylinder size='12.0 l' start='200.0 bar' end='30.0 bar' /> <weightsystem weight='8.0 kg' description='belt' /> <divecomputer> <depth max='18.0 m' mean='16.971 m' /> <temperature air='21.0 C' water='19.0 C' /> </divecomputer> </dive> </dives> </divelog>
_______________________________________________ subsurface mailing list [email protected] http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
