On 03.07.2014, at 07:55, Dirk Hohndel <[email protected]> wrote: > > I'm 13 commits into the rewrite. The editedDive plus the two pointers named > "current" in cylinders and weightsystems are gone. > > While I was at it I also implemented the "don't mark the maintab as editing > the dive until something was actually changed" feature that was requested > today... > > There is still quite a lot to do and to clean up, but I'm actually surprised > and pleased how far I've gotten. > > I decided to stop for today and continue when I'm more awake. > > Next step is to get rid of stagingDive in the planner. > > I'll push this out when it's ready for testing.
Dirk,
when you are done, could you help me with #585? The problem seems to be the
following:
in divelist.c there is the function init_decompression() which is supposed to
go through the dive list and find dives that still influence tissue loadings of
the current dive (in this case: in the planner). The rule is that we assume
that after 48h all tissues are back to their surface values. So from the
current dive we go back in time to find a surface interval of at least 48
hours. After that interval we take all the tissue loadings into account. There
seem to be two problems:
1) A minor one: the “going back in time” is done as a loop with
while (i && —i)
where i is the index in the dive list. Here, it seems to me i==0 is a perfectly
fine value, it is the first entry in the dive list. So the condition should
rather be
while (i >= 0 && --i >= 0)
Could somebody please confirm/refute this?
2) In the planner (this is why I write this), there seems to be a bogus dive in
the dive list present which seems to be related to the dive that is currently
planned and which for me is exactly one hour before the default date of the
planner (i.e. now). That dive is then counted as influencing the deco of the
planned one which is of course wrong. It seems to me this is one of the
“staging dive” or “current dive”. As I know you are looking into this, I will
not try to mess with trying to get rid of this dive or ignore it for pre
saturation of tissues. May I just draw your attention to this problem and ask
you to tell me when your open heart surgery has stabilized enough for me to
further investigate this point?
Thanks
Robert
--
.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO
Robert C. Helling Elite Master Course Theoretical and Mathematical Physics
Scientific Coordinator
Ludwig Maximilians Universitaet Muenchen, Dept. Physik
Phone: +49 89 2180-4523 Theresienstr. 39, rm. B339
http://www.atdotde.de
Enhance your privacy, use cryptography! My PGP keys have fingerprints
A9D1 A01D 13A5 31FA 6515 BB44 0820 367C 36BC 0C1D and
DCED 37B6 251C 7861 270D 5613 95C7 9D32 9A8D 9B8F
signature.asc
Description: Message signed with OpenPGP using GPGMail
_______________________________________________ subsurface mailing list [email protected] http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
