On Tue, Jul 08, 2014 at 07:37:28AM -1000, Gaetan Bisson wrote: > [2014-07-08 19:12:56 +0300] Miika Turkia: > > There is no visual indication that the GPS position > > is added before saving. (Once upon a time the GPS edit field was populated > > after selecting the location, if there was matching GPS coordinates > > available.) > > So the search loop ran for matching dive locations every time the > location name changes? Or perhaps just when the location field was > modified and then unselected? Or some other heuristic. None of these > seem as clean and simple as the current behavior.
It might make sense to have it run when focus leaves the location field? > > The GPS retrieval is not executed if I only re-type the dive location (e.g. > > clear the location and type it again, and save only after the whole edit). > > Yes it is, but you need to clear the GPS coordinates for that to work. > If there already are GPS coordinates, they are left as is. > > Dirk wanted to release 4.2 soon, I recall, and therefore I suggest it > incorporates the simple patch attached to restore the GPS completion > feature we had before. As you point out, further improvements could be > made but they are drastic and it seems wise not to delay 4.2 for them... 4.2 is a few weeks away. I still want to see a LOT more testing of the rather invasive changes I did last week. Maybe a first beta a week from now? /D _______________________________________________ subsurface mailing list [email protected] http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
