Re: Bug in restoring ascrate [was Re: Store/restore pref values for drop_stone_mode, bottomsac, decosac]

Thu, 17 Jul 2014 00:22:32 -0700


On 17.07.2014, at 09:04, Dirk Hohndel <[email protected]> wrote:

I traced this down to commit 887f9e63c3705df52b802420e72f5854d75c8ca6
Author: Tomaz Canabrava <[email protected]>
Date:   Tue Jul 15 15:39:13 2014 -0300

   Save and restore Dive Planner Settings


But I'm too tired and can't think straight. Clearly this messes up the
scaling and everything get's divided by 16.667 and therefore turns to 1.
But why and where (and why are these ints and why the hell can't I think
straight...)

Anyway, someone with more brain power than I please look at this.

Maybe more brain power (due to 5h of sleep) but unfortunately 0 spare time: 

I think, it’s the defaults that are wrong due to a unit confusion: We display the rates in meter or feet per minute but we store them in units of mm/sec. So the defaults should be in those units as well. Here is a patch.

Best
Robert

Attachment: 0001-Ascent-descent-rates-are-stored-in-mm-s-not-in-m-min.patch
Description: Binary data




-- 
.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO
Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics
                      Scientific Coordinator
                      Ludwig Maximilians Universitaet Muenchen, Dept. Physik
                      Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339
                      http://www.atdotde.de

Enhance your privacy, use cryptography! My PGP keys have fingerprints
A9D1 A01D 13A5 31FA 6515  BB44 0820 367C 36BC 0C1D    and
DCED 37B6 251C 7861 270D  5613 95C7 9D32 9A8D 9B8F




Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail

_______________________________________________
subsurface mailing list
[email protected]
http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

Reply via email to