Re: [PATCH v2 1/1] Update Subsurface with the updated QSysInfo from Qt 5.4

[Thiago Macieira]

On Sunday 17 August 2014 23:36:32 Dirk Hohndel wrote:
> CHRIST. Please. I am NOT INTERESTED in changing what is sent in the survey
> or as the User Agent string.
> 
> Now the survey changed to something like this:
> 
> survey?ssrfVers=4.2-55-gc935ffcca386&kernelType=linux&kernelVersion=3.15.8-2
> 00.fc20.x86_64&productType=fedora&productVersion=20&buildCpuArchitecture=x86
> _64&currentCpuArchitecture=x86_64&uiLang=en-US&suggestion=&recreational=1&te
> ch=1&planning=1&download=1&divecomputer=0&manual=0&companion=1"
> 
> instead of
> 
> survey?ssrfVers=4.2.0&prettyOsName=OS%20X%20Mavericks%20(10.9)&appCpuArch=x8
> 6_64&uiLang=en&recreational=0&tech=1&planning=1&download=1&divecomputer=1&ma
> nual=0&companion=0&suggestion=
> 
> I don't give one yota which kernelVersion the user runs. I quite
> intentionally want to send the "prettyOSVersion" I don't want to change the
> "appCpuArch=" parameter to "buildCpuArchitecture=" etc.

The problem is that the functions in QSysInfo changed for Qt 5.4. For 
appCpuArch I could leave the build CPU arch, but the pretty name will not 
contain the same information. 

So I can change to send the same fields, but the content will change slightly.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

_______________________________________________
subsurface mailing list
subsurface@hohndel.org
http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface