On Friday 22 August 2014 00:33:56 Salvo Tomaselli wrote:
> In data giovedì 21 agosto 2014 11:42:59, Thiago Macieira ha scritto:
> > Have you tested this? I'm trying here and the generated Makefile is
> > identical to the one without this patch.
>
> Well I guess you'd need to set some CFLAGS to see some effects.
>
> I did try to build a debian package with and without this patch, using the
> hardening flags (stack protector, random locations and so on) and results
> were different. And if it had worked from the beginning I wouldn't have
> sent a patch, so I think there is a problem with CFLAGS being ignored.
I see. I thought you meant make arguments passed on the command-line
make CFLAGS=xxxx
You meant environment variables set during qmake time. Then yes, that makes
sense. The patch is good.
--
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
Software Architect - Intel Open Source Technology Center
PGP/GPG: 0x6EF45358; fingerprint:
E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358
_______________________________________________
subsurface mailing list
[email protected]
http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
