Hi Lubomir... good to have you back with patches!
On Mon, Oct 27, 2014 at 11:41:53AM +0200, Lubomir I. Ivanov wrote: > >> please ignore anything in particular if you see fit. > >> i'm not really advocating any of these. I liked all of them except for one... > >> [PATCH 5/9] divelogexportdialog.cpp: attempt to fix a 'unsigned / The original code clearly has issues, but so does your patch. Something is fishy if the offset can be negative but we compare it against a time that's unsigned. I need to stare at the code and look at the values a bit longer - or maybe you could do that (as I won't have time until late tonight, I think). Everything else I will push in a moment once my test builds finish. /D _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
