Robert,
Specifically for Poseidon input, one needs to know which is the oxygen and which is the diluent. Like, I suppose, for any specific machine there will be a particular assignment of cylinders. Nowhere outside of the code that specifically reads Poseidon CSV do I use specific cylinder assignments as numbers.
Does this make sense at all?
Kind regards,
willem


On 08/11/2014 16:21, Robert C. Helling wrote:
Willem,



Am 08.11.2014 um 13:34 schrieb Willem Ferguson 
<[email protected]>:

in file.c, for Poseidon input, ensure that the cylinder index is
    hard-coded by setting sample->sensor to 0.
2) For the three cases above, ensure that function
    populate_pressure_information() in gaspressures.c assigns the
    correct cylinder indices. This is performed by using a small
    lookup-table, rather than using complex if--else constructs.
I thought we had decided against using magic numbers. Why would you force a 
specific number rather than setting the appropriate label?

Best
Robert


--
Willem Ferguson
Director: Centre for Environmental Studies,
University of Pretoria
Tel: 012-4202017 / 012-4204048
e-mail: [email protected]

_______________________________________________
subsurface mailing list
[email protected]
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Reply via email to