On Tue, Nov 18, 2014 at 08:41:26AM +0000, Dirk Hohndel wrote: > > So I assume this patch is not acceptable? Would you like me to re-draft the > > patch in line with you comments? > > No, I wanted to see your comments to understand what's going on. > I still want to understand what pressures.o2 does... > > I'll take the patch and hope that you'll send patches on top of it to get > CCR closer to ready for Beta 2
BTW, as a general rule. If I look at the patch, it does four things. While this may seem silly, I would have MUCH preferred four patches that each do one thing. Each with their own commit message. Etc. But as I said, I took what you sent (but I rewrote the commit message to be less... personal). /D _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
