On Tue, Jan 06, 2015 at 06:24:08PM +0100, Anton Lundin wrote: > On 06 January, 2015 - Joakim Bygdell wrote: > > > > > > On 06 Jan 2015, at 17:15, Anton Lundin <[email protected]> wrote: > > > > > > This unifies how we prints Nitrox deco gas dives with Trimix deco gas > > > dives. > > > > > > Signed-off-by: Anton Lundin <[email protected]> > > > --- > > > > > > This is the opposite from what Jocke's patch does. After looking at my > > > dive > > > list i think i actually like this one better. > > > > > > What do other folks think? > > > > > > - snprintf(buffer, MAX_GAS_STRING, "%d/%d", o2, he); > > > + if (o2 == o2max) > > > + snprintf(buffer, MAX_GAS_STRING, "%d/%d", he, > > > o2); > > > > Shouldn’t this line read snprintf(buffer, MAX_GAS_STRING, "%d/%d", o2, > > he); > > or you will get really low fO2 in your air-topped gas mix. > > > > Yep. Nice catch of this typo. > > > Dirk: Would you do the honers and correct the patch or would you like me > to re-send it as a v2?
I'd prefer a v2 - but we are still figuring out what to do here. So far the opinions are rather widely spread... /D _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
