[PATCH 1/5] add and use a version.c / version.h pair was discussed with Anton and Dirk previously and is a very nice thing to have. as mentioned in the commit message we can use constants instead of functions. let me know if you want me to change the patch to that.
i would use functions for API calls. [PATCH 2/5] OS: add the subsurface_mkdir() wrapper build is broken without it. Linux and OSX are untested. [PATCH 3/5] qthelper.cpp: use QStandardPaths::DataLocation for older build is broken on Qt 5.3. patch branches the newer enum value for Qt >= 5.4. [PATCH 4/5] parse-xml.c: remove unused variables in [PATCH 5/5] downloadfromdivecomputer.cpp: fix initializer list order these two fix a couple of warnings lubomir -- _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
