On Mon, Mar 09, 2015 at 04:01:12PM -0300, Tomaz Canabrava wrote:
> From 7e89b79afbefd508015841a667cc68a73865754b Mon Sep 17 00:00:00 2001
> From: Tomaz Canabrava <[email protected]>
> Date: Mon, 9 Mar 2015 15:12:48 -0300
> Subject: [PATCH 3/6] Remove redundant code
>
> Another bit of piece of software that shouldn't exist.
>
> Signed-off-by: Tomaz Canabrava <[email protected]>
> ---
> qt-ui/maintab.cpp | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/qt-ui/maintab.cpp b/qt-ui/maintab.cpp
> index 956a1bc..dff49d8 100644
> --- a/qt-ui/maintab.cpp
> +++ b/qt-ui/maintab.cpp
> @@ -71,6 +71,7 @@ MainTab::MainTab(QWidget *parent) : QTabWidget(parent),
> // filled from a dive, they are made writeable
> setEnabled(false);
>
> +
Really?
> @@ -955,10 +956,7 @@ void MainTab::markChangedWidget(QWidget *w)
> qApp->palette().color(QPalette::Text).getHslF(&h, &s, &l, &a);
> p.setBrush(QPalette::Base, (l <= 0.3) ? QColor(Qt::yellow).lighter() :
> (l <= 0.6) ? QColor(Qt::yellow).light() : /* else */
> QColor(Qt::yellow).darker(300));
> w->setPalette(p);
> - if (!modified) {
> - modified = true;
> - enableEdition();
> - }
> + modified = true;
Are you sure this is correct? I thought the first time something changes
we do have to call enableEdition() - or is this taken care of somewhere
else?
/D
_______________________________________________
subsurface mailing list
[email protected]
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
