Hi Jan... On Sat, Mar 14, 2015 at 06:03:57PM +0100, Jan Darowski wrote: > From a66d28496ed2558b737ebb004ad2d84d3ae807bb Mon Sep 17 00:00:00 2001 > From: Eltharan <[email protected]> > Date: Sat, 14 Mar 2015 15:35:47 +0100 > Subject: [PATCH 1/2] Refactored image timestamp checking. > > Seperated getting image timestamp from picture_load_exif_data() and > ShiftImageTimesDialog::syncCameraClicked() into picture_get_timestamp() > and seperated checking timestamp from dive_create_picture() to > dive_check_picture_time().
This seems reasonable... The patch had a couple of whitespace issues (trailing space, more specifically empty lines that weren't empty but had one space in them) but other than that looked good. I don't use this feature in Subsurface, so I haven't really tested this, but the code looks correct. /D _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
