On 20 March 2015 at 23:06, Claudiu Olteanu
<[email protected]> wrote:
> Hi there,
>
> Here is a patch which fixes the #844 ticket.
lines 31 and 38 of the patch contain trailing whitespace.
before committing you can use:
git diff --check
- filename = QFileDialog::getSaveFileName(this, tr("Save file as"),
default_filename,
- tr("Subsurface XML files (*.ssrf *.xml *.XML)"));
(1) i know the original wasn't either...
+
+ QFileDialog selection_dialog(NULL, tr("Save file as"), default_filename,
+ tr("Subsurface XML files (*.ssrf *.xml *.XML)"));
+
(2)...but the second line - tr(....) should be preferable indented
with spaces like so:
(should be viewed with a monospace font)
QFileDialog selection_dialog(NULL, tr("Save file as"), default_filename,
tr("Subsurface XML files (*.ssrf *.xml *.XML)"));
or with a single tab.
NULL for parent in QFileDialog seems to work, but any reason to change that?
everywhere else in mainwindow.cpp we use "this".
other than these two small remarks, the change seems about right.
lubomir
--
_______________________________________________
subsurface mailing list
[email protected]
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
