Not bogus, I didnt hardcoded the library, just the string. If you pass - DPREFER_GIT_FROMSOURCE=OFF it will try to use the system one.
Em Ter, 7 de abr de 2015 19:38, Dirk Hohndel <[email protected]> escreveu: > On Tue, Apr 07, 2015 at 06:55:45PM -0300, Tomaz Canabrava wrote: > > Subject: [PATCH 06/15] Added an option to toogle between distro and ours > > libgit. > > > > Signed-off-by: Tomaz Canabrava <[email protected]> > > --- > > CMakeLists.txt | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/CMakeLists.txt b/CMakeLists.txt > > index 4b434f5..9ac3e29 100644 > > --- a/CMakeLists.txt > > +++ b/CMakeLists.txt > > @@ -7,6 +7,8 @@ cmake_minimum_required(VERSION 2.8.11) > > > > SET(CMAKE_AUTOMOC ON) > > SET(CMAKE_AUTOUIC ON) > > +OPTION(PREFER_GIT_FROMSOURCE "Turn off if you wanna use system's libgit > 0.21.5" ON) > > Ignoring the casual language... that's of course bogus because you > hardcode the library version number instead of showing which library is > actually installed... > > So I guess I don't understand the patch... > > I'll include it as I don't want to break the series, but this seems bogus > > /D >
_______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
