Good night.

Actually,  dive rating is not saved after editing it.  The issue seems to
raise from a mistake in ebaa7d1fd.

Attached patch should solve it.

Regards.

Salva.
From 75f7b16ca583a5a3095016382cf172c14cbc9e8a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Salvador=20Cu=C3=B1at?= <[email protected]>
Date: Fri, 29 May 2015 00:10:09 +0200
Subject: [PATCH] Correctly save dive rating after changing it
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Corrects typpo on ebaa7d1fd which impeded that changes in dive rating
were saved after editing.

Signed-off-by: Salvador Cuñat <[email protected]>
---
 qt-ui/maintab.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qt-ui/maintab.cpp b/qt-ui/maintab.cpp
index 88bcc83..3d17bcd 100644
--- a/qt-ui/maintab.cpp
+++ b/qt-ui/maintab.cpp
@@ -782,7 +782,7 @@ void MainTab::acceptChanges()
 			MODIFY_SELECTED_DIVES(EDIT_TEXT(suit));
 		if (!same_string(displayed_dive.notes, cd->notes))
 			MODIFY_SELECTED_DIVES(EDIT_TEXT(notes));
-		if (!same_string(displayed_dive.divemaster, cd->divemaster))
+		if (displayed_dive.rating != cd->rating)
 			MODIFY_SELECTED_DIVES(EDIT_VALUE(rating));
 		if (displayed_dive.visibility != cd->visibility)
 			MODIFY_SELECTED_DIVES(EDIT_VALUE(visibility));
-- 
2.1.4

_______________________________________________
subsurface mailing list
[email protected]
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Reply via email to