On Wed, Jun 17, 2015 at 05:58:43PM +0200, Gehad Elrobey wrote: > On Wed, Jun 17, 2015 at 5:13 PM, Dirk Hohndel <[email protected]> wrote: > > > Hey Gehad, > > > > I know you are focused on this year's GSoC project right now, but I have a > > question about your previous contribution, the HTML exporter... > > > > For me (Firefox 38.0.5, Arch Linux) the expansion by clicking on an entry > > in the dive list doesn't work. I get nothing at all. The Expand All button > > works. > > > > This is what I see in source view: > > > > <ul id="290" ul="<=" onclick="toggleExpantion(event, this)" > > style="padding: 2px 10px;"> > > > > What I don't understand about this line is the ul attribute. It doesn't > > appear to exist based on my reading of the standard and when I ask Firefox > > to copy the html what it does seems to indicate that it might be confused > > by that ul attribute as well: > > > > <ul style="padding: 2px 10px;" id="290" onclick="toggleExpantion(event, > > this)" <="" ul=""> > > > > see how it creates a '<' attribute here? > > > > Something is definitely wrong there. > > > > Any idea? > > > > Hello Dirk, > > I couldn't reproduce this on Chromium but I still see the malformed Html it > seems that Chromium is more tolerant to incorrect tags, I have attached a > patch that fixes the tag closing, I hope this will fix the problem.
Well, the HTML looks much better now, but the problem isn't fixed. While I am not a JS programmer by any stretch of the imagination, I tried debugging it a little... Firebug tells me that at the beginning of the toggleExpantion() function (umm - what's Expantion? Were you thinking of Expansion?) we derefernce e.toElement.localName but e.toElement is undefined... Does this help figuring out what's going on? /D _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
