On 1 July 2015 at 03:24, Gehad Elrobey <[email protected]> wrote: > > > On Tue, Jun 30, 2015 at 11:13 AM, Lubomir I. Ivanov <[email protected]> > wrote: >> >> On 30 June 2015 at 03:53, Gehad Elrobey <[email protected]> wrote: >> > >> > >> > On Mon, Jun 29, 2015 at 4:13 PM, Lubomir I. Ivanov <[email protected]> >> > wrote: >> >> >> >> On 29 June 2015 at 05:08, Gehad Elrobey <[email protected]> wrote: >> >> > Hello all, >> >> > >> >> > This week I was working on the list of tasks which I have discussed >> >> > with >> >> > Lubomir. >> >> > >> >> > Tasks completed so far: >> >> > - QPrintPreviewDialog triggered from the main dialog >> >> >> >> nice >> >> >> >> > - add "print selected dives" support >> >> >> >> this one doesn't work for me. i have a massive test list of dives and >> >> with "print selected dives" not selected, i expect it to print the >> >> entire list, instead it prints only a single page with two dives. >> >> >> > >> > That was working for me before I merged commit 094264014dc47, it seems >> > that >> > amount_selected in display.h is not working as expected, I will look >> > into >> > this and push a commit. >> > >> >> ok >> >> >> >> >> > - print in colors or gray scale >> >> >> >> does not work. the profile is still printed in color no matter the >> >> print dialog selection. >> >> do you simply attempt to greyscale the profile image before rendering >> >> on the HTML? >> > >> > >> > I use QPrinter::setColorMode() which selects the color mode for the >> > printer >> > to be RGB or Gray scale, anyway the output in the QPrintPreviewDialog is >> > always in RGB mode, while actual printing using the printer is working >> > correctly for me. >> > >> >> greyscale should work for both the preview and the actual print. >> > > I think QPrintPreviewDialog reflects page related options only, so some > QPrinter related settings like colorMode and resolution can't be previewed > with the dialog. >
how so? in *all* of the previous implementations both resolution and colorMode were visible/reflected on the preview! both PrintDialog::onPaintRequested() and PrintDialog::printClicked() call the same method Printer::print() which then calls Printer::render() and greyscale mode becomes optional. what am i missing? > Also as you have mentioned that profile2 is missing grey scale capability so > I think we may need to remove 'print in color' check box which is in my > opinion useless, because user can still select printing color mode from > option tab in QPrintDialog which will affect the actual printing and not the > previewDialog. > > i disagree...the Preview should be exactly the same as the Print output. the profile2 custom color table is also doable but for now we should simply use QPrinter::GrayScale. BTW, Gehad we had a short discussions with the other GSoC mentors and we came to the conclusion that some of the students are not very responsive. i know that i'm not on IRC, and i'm not saying that you don't respond at all, but could you try to be *more* responsive via email i.e. write immediately after you see an email, cover all questions etc...this is important for your final GSoC score. lubomir -- _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
