On Mon, Jul 06, 2015 at 11:55:38AM +0300, Grace Karanja wrote: > On Mon, Jul 6, 2015 at 1:51 AM, Dirk Hohndel <[email protected]> wrote: > > Things looks nice, great progress. Styling is a bit off on my display (text > > seems to be too close to the bottom of the surrounding box) but it's quite > > usable already. It's just so cool when you add your credentials and it > > simply shows all your dives... > > Thanks. I am working on improving the UI issues. Once I have a dive profile > in place, I should be able to implement some swipe gestures.
Good. > > That will be cool. I am really happy how close to useful this is already - > > and we only at about half time of the project! > > > > > and > > > - Spend time on improving Android compilation. As the app has only been > > tested > > > on desktop, we will need to run it on Android for better testing. > > > > Definitely. Please keep asking Anton(glance) to help you there. Worst case > > I can try and dig into what I can find... I don't consider fixing the > > cmake problem part of your GSoC tasks and don't want you to have to waste > > too much time on this. > > > > > All of the work done so far is on my GitHub repository. > > > > I pulled from there to play with things. I'm not quite ready to pull this > > into master because there seems to be too much redundant code movements. > > One patch moves code here, the next patch moves it there. > > One patch comments out code, the next patch remove the comment. > > Several patches have incremental changes to the same file. > > > > I know that you have used git rebase -i in the past. I'd really like to > > see you combine some of these commits so the series of patches becomes > > more structured and goes reasonably straight to the end result. > > > > From a commit message point of view I think you are doing well. One thing > > that would be nice would be a "tag" in the commit title. For example if > > all of the commits that deal with the QML UI started with "QML UI:" and > > continued in lower case. Something like > > > > QML UI: implement saving dives in the cloud > > Thanks...I will redo the commits in this format :) Thank you. I look forward to a fresh pull request. /D _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
