On 13 July 2015 at 23:54, Gehad Elrobey <[email protected]> wrote: > > > On Mon, Jul 13, 2015 at 10:33 PM, Lubomir I. Ivanov <[email protected]> > wrote: >> >> On 13 July 2015 at 22:35, Gehad Elrobey <[email protected]> wrote: >> > Hello all, >> > >> > This week I was working on the following tasks: >> > >> > - Enhancing the one dive per page template. >> > - Refactoring the Printing class to handle QPrinter and QPixmap. >> > - Implement the Preview section in "TemplateEdit" dialog. >> > - Adding color tab to "TemplateEdit". >> > - Adding color palettes to template settings. >> >> nice, i will take a look tomorrow. >> >> > >> > This week I will mainly work to enhance the user experience and add >> > remaining templates (eg. flow layout), Also I want to fix any bugs as >> > soon >> > as possible so testing the whole thing now can be very useful. >> > >> > I have done some work to fix the gray-scale issue in the dive profile, I >> > have attached a picture of the dive profile after my progress, But there >> > are >> > still some dive profile items that I couldn't change to gray-scale (eg. >> > numbers on the axis and the cylinder pressure curve), I also needed to >> > change the QPixmaps to QImages and transformed them to gray-scale >> > manually, >> > So I am not sure If I am progressing in the correct direction regarding >> > the >> > dive profile gray-scale issue. >> > >> >> at least a couple of times, i've said to approach the whole thing >> using the "convert everything to greyscale via CSS" method. >> mind that this is a feature that is not very important (not that many >> "i want to print in greyscale" requests by users out there) and we >> should attempt to save time by doing the easier solution. the approach >> of "let's bring back the custom greyscale color table that was in >> Profile1" is going to eat a lot time and is questionable as a >> maintainable code-base feature, unless we decide to add customizable >> user colors in the profile at some point. >> >> have you encountered problems with the CSS filter approach? >> > > As the dive profile is rendered on top of the QWebView after the Html page > is already displayed. the css filtering will not affect the dive profile and > will only affect the content of the HTML page, that's why I though I should > render a gray scale version of the dive profile. >
i forgot about that part. in that case, use the CSS filtering on the QWebView page but also convert the whole profile QImage/QPixmap to greyscale (not individual profile item classes using the custom color table). lubomir -- _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
