On Fri, Jul 17, 2015 at 10:27:19AM -0700, Dirk Hohndel wrote: > On Fri, Jul 17, 2015 at 02:15:53PM -0300, Tomaz Canabrava wrote: > > From 07778598514461748a9f679d523283bda5609bcc Mon Sep 17 00:00:00 2001 > > From: Tomaz Canabrava <[email protected]> > > Date: Fri, 17 Jul 2015 14:08:01 -0300 > > Subject: [PATCH 2/2] Make sure we don't pass the wrong info > > > > We where returning true here, which meant that we where > > Ignoring the spelling issue (were/where), the commit message doesn't make > any sense. Your patch makes it return true. So I assume the commit message > should read > > "We were returning false here which meant that we were overriding > the information with the wrong value later."
Having said all this, yes, the patch fixes the bug. So to those of you considering testing this (you ARE going to test this, right? after all the fighting and yelling...) - please pull the latest master or get the -1141 daily builds that are being created as I speak. I really think this is a) very usable and b) better than what we had in 4.4 and earlier. /D _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
