> On 30 Jul 2015, at 16:22, Dirk Hohndel <[email protected]> wrote: > > On Thu, Jul 30, 2015 at 04:20:57PM +0200, Joakim Bygdell wrote: >> >>> On 30 Jul 2015, at 16:18, Dirk Hohndel <[email protected]> wrote: >>> >>> On Thu, Jul 30, 2015 at 04:03:58PM +0200, Joakim Bygdell wrote: >>>> >>>>> On 30 Jul 2015, at 15:22, Dirk Hohndel <[email protected]> wrote: >>>>> >>>>> On Thu, Jul 30, 2015 at 11:41:11AM +0200, Joakim Bygdell wrote: >>>>>> In order to have a consistent look of the GUI the top bars needs to have >>>>>> the same dimensions. >>>>>> Texts and buttons should be placed in the same positions and the buttons >>>>>> should have a decent size. >>>>>> >>>>>> 0001 sets the preferred width of the buttons to 10% of the screen width. >>>>>> 0002 color and position fixup so that the top bar in dive detail view >>>>>> matched the one in main view. >>>>> >>>>> I agree with the sentiment of the patch, but just from using other Android >>>>> apps it appears to me that the back button is usually in the top left >>>>> corner while the menu button usually is in the top right? >>>> >>>> That might be the case but our button does not only return the user to the >>>> main view. >>>> It also saves any changes made to the dive, that needs to be obvious to >>>> the user as well. >>>> >>>> How to solve that is another issue, maybe a drop down menu that says “save >>>> and return”. >>>> Since pressing the return button on the device will transport the user >>>> back to the main view as well. >>> >>> Then our button should be a save button - or two different buttons >> >> We could place a return button at top left and a save & return at bottom >> right. >> That way they are clearly separated both in position and in action. > > Yes, I'd loke that better. > > I have a patch that moves the button back to the left and centers the > "Subsurface mobile" text in both cases... I'll drop that and wait for your > next patch, ok?
Do that. > > /D /Jocke
_______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
