Hi guys. 2015-08-10 17:01 GMT+02:00 Miika Turkia <[email protected]>:
> On Mon, Aug 10, 2015 at 10:01 AM, Dirk Hohndel <[email protected]> wrote: > > > I'm reasonably certain that I tested the existing code and that it works > - > > I'm ok being proven wrong, but I'd like to make sure that this is at > least > > tested and not submitted as "I didn't test it but the original code > looked > > wrong" :-) > > What strikes me odd is that the first angle bracket ([) is escaped but > the closing one (]) is not. The original code escaped them both > (overwritten by commit 152eeb45d64db1398145ef7a935a132707b75e43), but > the improved code lost the escaping from the closing angle bracket. > > I've been testing this a bit and, curiously, both regexps worked fine. Tested on local git repository from CLI and form GUI. Couldn't test on remote git as I couldn't achieve a conection with the server (always getting an error). Regards Salva.
_______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
