On Sat, Aug 22, 2015 at 08:28:02AM +0200, Salvador Cuñat wrote: > Good morning. > > It looks like that 72806e4 breaks building the automated html exporter by > including the mainwindow.h file.
It also broke the tests (which shows you that I don't run the tests often enough... shame on me). > Adding the dependencies required to link produces a 22mb executable, which > seems pretty much for a non-gui standalone tool (I think previously it was > about 4mb). > > Attached patch, although solves the build problem, is not meant to be > applied, just to show what I'm talking about. The correct solution would > probably be to put the helper in_planer() function elsewhere, or change it > to avoid the need of mainwindow.h Yeah, your patch simply shows what's broken. Logic code must not call UI code. It's sad to admit that Robert pointed out to me that this was a bad idea, yet I asked him to do this and then didn't think through his implementation. I just pushed a fix that corrects the error and make both export-html and the tests work again. Thanks for pointing this out! /D _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
