On 22 August 2015 at 17:09, Gehad Elrobey <[email protected]> wrote: > > > On Fri, Aug 21, 2015 at 9:38 PM, Lubomir I. Ivanov <[email protected]> > wrote: >> >> On 21 August 2015 at 20:52, Gehad Elrobey <[email protected]> wrote: >> > >> > >> > On Tue, Aug 18, 2015 at 10:06 AM, Lubomir I. Ivanov >> > <[email protected]> >> > wrote: >> >> >> >> On 18 August 2015 at 03:51, Gehad Elrobey <[email protected]> >> >> wrote: >> >> > Hello Lubomir, >> >> > >> >> > As I am progressing with the documentation, I want to add description >> >> > for >> >> > users willing to write their own templates, so I will need to >> >> > describe >> >> > many >> >> > concepts related to our defined css selectors, Grantlee names, etc. >> >> > do >> >> > you >> >> > think it is relevant to add these details in the user manual? or we >> >> > better >> >> > separate it in a special page on subsurface website for example? >> >> > >> >> >> >> hello, >> >> CCing Dirk, just in case he objects with my proposal. >> >> >> >> i'd say, just add this in the main documentation file for now, but >> >> please try keeping it short - only listing the Grantlee variables and >> >> having a brief explaination on how a template works, the CSS etc... >> >> >> >> i think the manual should be a multi-page HTML at this point instead >> >> of one file, as it becomes difficult to maintain by multiple users. >> >> >> > >> > Hello Lubomir, >> > >> > I pushed the latest commits which contains the following updates: >> > >> > - Updating the printing section in the user-manual. >> > - Adding "Appendix F" which describes how to write a custom template as >> > Dirk >> > suggested. >> > - Implemented the code which exports statistics data structures to >> > Grantlee >> > backend. >> > - Make the statistics templates editable (we can also add the >> > import/export >> > statistics templates very easily later). >> > - Fix issue in six dives template. >> > >> > I pushed them now as today is the hard deadline for this project in the >> > scope of GSoC, But I think I will work on additional enhancements before >> > the >> > release anyway. >> > >> >> nice, >> >> i will add user-manual comments about typos and such here: >> >> https://github.com/Gehadelrobey/subsurface/commit/b0a9596997a57e79e82b47f7c69889ede78d502f >> >> std::ceil() in printer.cpp throws an error in mingw. >> just replace all usage of std::ceil() with qCeil() from <QtMath>. >> >> but please wait for my user-manual comments to be finished before >> updating your github three. >> WIP... >> > > Updates pushed. >
thanks, will send the PR in a minute. can we eventually support HTML/CSS editing of the statistics template, for instance - adding/removing table columns such as year.avg_depth, year.max_depth etc? does that mean we need another Custom.html? actually, this opens some questions about the Custom.html concept...something that i have missed. how can the user edit, say the 6-dives template and save it from Subsurface? it always saves to the Custom.html template and editing in place is not possible. of course this is nice in a way, as they can't modify the bundled templates but i think *they should* and it's their problem if they make one of the bundled templates bad. editing in-place is the way to go, which means that if the user edits "Six Dives.html" and presses "save" the actual "Six Dives.html" is saved - this removes the need for Custom.html. what do you think? sorry for the late change request, but hopefully that won't break a lot of things. no user feedback yet, but GSoC wise, we are pretty much done. great work! lubomir -- _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
