On 13 September, 2015 - Dirk Hohndel wrote: > > > On Sep 13, 2015, at 8:46 AM, Anton Lundin <[email protected]> wrote: > > > > On 13 September, 2015 - Anton Lundin wrote: > > > >> This removes leftover bits from when setpoint and sensor values where > >> treated the same way. > >> > > > > I was/still are to tired to write good commit messages. > > > > Here comes some explanation. > > > > Previously subsurface treated DC_SAMPLE_SETPOINT and DC_SAMPLE_PPO2 the > > same way. > > > > Back in "Store DC_SAMPLE_PPO2 as a o2 sensor", and "Support multiple o2 > > sensor values from libdc", i changed that and started to treat > > DC_SAMPLE_PPO2 as the o2 sensor values they are. > > > > The po2 variable there was a leftover from when ppo2 and setpoints where > > treated the same way, and should be removed. > > So we have a weird hack in the Shearwater support in our libdivecomputer > branch > that was trying to work around something there... can you check if that is > still useful > or if we should revert that, now that we treat the different sample types > correctly? >
With wierd hack you mean "Predator: don't report PPO2 unless in CC mode" that patch is still valid. I was just cleaning up after dinner and it struck me that we need to set no_o2sensors for things to work propperly. I'll try to globber up a patch for that if the little one lets me. //Anton -- Anton Lundin +46702-161604 _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
