On Tue, Sep 29, 2015 at 01:19:13AM +0300, Guido Lerch wrote: > > Hi Dirk > > I am fine, of course, with Linus' patch. > I dispute however that I was ever against the threshold unless I > misunderstand something here. I also did no changes to any code > concerning threshold. My work was focussed on getting the raw data in > trying to deal with all uemis oddities. > > You and I never discussed a threshold, that must have been someone else.
Entirely possible that I'm making this up. Hey, I'm narced from spending more than 4 hours sub-surface today :-) I thought we discussed why the dive duration with the Uemis wasn't as you expected it to be... either way, maybe I changed the actual code based on your feedback, I'd have to dig in the git log to remind myself what exactly happened here. > Nevertheless I'll try to get the last master with my lousy internet > connection here in Egypt and continue testing. Excellent. > I still suffer from not knowing the code too well and need to still learn a > lot. Yes, it's a big code base by now. It takes a while to get used to it. And frankly, there are many developers here who are quite familiar in one part and completely at a loss in many other parts. I maintain this project and can't claim that I fully understand the XSLT transformations or the inner workings of our model/view stuff and quite a few other areas of the code. > For example while trying to implement the pressure drop approach I found > that even changing the base64 string wouldn't to anything to the > equipment data nor the sac calculations. I spend 2 hours and didn't find > out why because I am still so new to anything that is outside the uemis > loader that I start to wonder whether I am useful at all. I found your Uemis code extremely useful. When in doubt, ask. Linus and I have written a good chunk of the inner workings of the code (the old C part that deals with a lot of the stuff you ask about) and we'll be happy to help. /D _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
