On 5 October 2015 at 13:19, Lubomir I. Ivanov <[email protected]> wrote: > On 5 October 2015 at 13:10, Dirk Hohndel <[email protected]> wrote: >> On Mon, Oct 05, 2015 at 12:18:08PM +0300, Lubomir I. Ivanov wrote: >>> On 5 October 2015 at 10:16, John Smith <[email protected]> wrote: >>> > >>> >> > I had done an uninstall prior to installing but some of the logs were >>> >> > kept from the last installation and loaded at startup. >>> >> >>> >> Yes, we intentionally keep settings and data files. Do you think that's a >>> >> mistake? >>> >> >>> > Ater a uninstall I would have expected a clean installation with no >>> > previous fles - maybe as part of the uninstall routine you could change >>> > the >>> > names to .old or put them in a different location >>> > >>> >>> what we do is something that a lot of Windows software does... >>> it installs in a program directory but it keeps some of it >>> files/settings on the user computer on uninstall without telling. >>> that's not optimal, but like i said, 95% of the Windows software does the >>> same. >>> >>> what we could do is add the uninstall options to remove the left overs: >>> >>> - user directory >>> moving files to .old becomes difficult to maintain. >>> we should allow deleting the whole directory e.g.: >>> C:\Users\<name>\AppData\Roaming\Subsurface >> >> I'm not an expert on NSI files... I'm sure this is something that could be >> added to our .nsi file. >> >>> - cloud storage cache directory >>> C:\Users\<name>\AppData\Local\Subsurface >>> currently this is in a separate path from the other user directory >>> which makes no sense. we should use the same path and add >>> sub-directory called git-cache. >> >> Possibly. But I question whether we should do this after Beta 3 has been >> released. Stuff like this frustrates me. This has been in the code for >> MONTHS. > > all uninstaller changes should be post 4.5, i would say. > >> >>> both paths can be stored in the registry from where NSIS would know >>> what to delete. >>> >>> - registry >>> this can be nuked completely as the last step. i really like software >>> that bothers exposing a checkbox for that. >>> but i don't really know how to do checkboxes in NSIS, yet. >> >> So who is fluent in NSIS? >> > > i'm reading it right now and doing some tests, but adding the custom > checkboxes seems a bit complicated. >
i was able to figure out how to do that in NSIS... basically, what it does is before performing the uninstall the user has a blank page with 2 checkboxes. one for removing the registry key and one for removing the user directory (should be only one for both the git cache and the user files - a separate patch). suggesting the following verbose texts for the CBs: [x] Remove registry key (HKCU...<somewhere>) [x] Remove user folder (C:\users\...<somepath>) please confirm the above strings and i will send patches after 4.5 is released. lubomir -- _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
